[java] Fix broken LICENSE link in java/README.md - #2553
Open
rinceyuan wants to merge 1 commit into
Open
Conversation
The License section pointed at java/sdk/LICENSE, which does not exist. No java-local LICENSE has ever been tracked; the only LICENSE files in the repo are the root LICENSE and rust/LICENSE. Retarget the link to the repository-root ../LICENSE.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The link-only change correctly targets the existing root license, with no unresolved issues.
Pull request overview
Fixes the broken license link in the Java README by pointing to the repository-root license.
Changes:
- Updates
sdk/LICENSEto../LICENSE.
File summaries
| File | Description |
|---|---|
java/README.md |
Corrects the MIT license link. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The License section of
java/README.mdlinks tosdk/LICENSE, which resolves tojava/sdk/LICENSE— a path that does not exist. The link 404s on GitHub.No java-local
LICENSEhas ever been tracked in this repository, so the link has been dead since it was introduced; thejava/src→java/sdkrestructure in #2301 only changed which nonexistent path it pointed at (LICENSE→sdk/LICENSE). This retargets it to the repository-root../LICENSE.Verification
The only LICENSE files tracked in the repo:
java/LICENSEwas never tracked, so the pre-restructure link was dead too:Before / after, resolved relative to
java/README.md:sdk/LICENSE(before)java/sdk/LICENSE../LICENSE(after)LICENSEScope
One line in one file.
java/README.mdis the only README that links to a LICENSE file —nodejs,go, anddotneteach render a bareMITunder## License, andrust/pythonhave no License section at all — so nothing else is affected.